Add on-push retrying info to debug agent and fix typo in build pipeline definition#5008
Open
jvulgan wants to merge 2 commits into
Open
Add on-push retrying info to debug agent and fix typo in build pipeline definition#5008jvulgan wants to merge 2 commits into
jvulgan wants to merge 2 commits into
Conversation
Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Document how to retry failed on-push pipelines for the original commit, using the current pipeline spec (not the archived one) to avoid stale task bundle digests failing EC checks. Always inject the ignore-supersession annotation to prevent snapshot supersession. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Reviewer's GuideDocuments a safe, correct procedure for retrying failed on-push Konflux pipelines for the original commit, adds guidance to avoid using the Konflux UI 'Rerun' button, and fixes a typo in the build pipeline parameter definition. Flow diagram for retrying a failed on-push pipelineflowchart TD
A["On-push PipelineRun failed with transient error
(e.g. registry 503, image pull backoff)"] --> B{"Need to retry?"}
B -->|No| Z["Stop"]
B -->|Yes| C{"Use Konflux UI Rerun?"}
C -->|Yes| D["Do NOT use Konflux UI Rerun
It re-resolves {{revision}} to latest main
and builds wrong commit"]
D --> C
C -->|No| E["Fetch original PipelineRun JSON
oc get pipelinerun ...
or kubectl ka get ..."]
E --> F["Verify revision and title
with jq from archived-plr.json"]
F --> G["Convert current .tekton/build-pipeline.yaml
spec to JSON with python3"]
G --> H["Build retry PipelineRun JSON
with jq:
- archived .spec.params
- current pipelineSpec
- adjusted annotations/labels
- git-auth-dummy workspace
- ignore-supersession annotation"]
H --> I["Create new PipelineRun
oc create -f /tmp/retry-plr.json"]
I --> J["Verify retry started
oc get pipelinerun ...
filtered by revision"]
J --> Z
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
@calungaproject/developers ptal |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The retry script hardcodes values like the
calunga-tenantnamespace,.tekton/build-pipeline.yamlpath, andgit-auth-dummysecret; consider calling these out as variables/placeholders at the top of the snippet so they’re easier to adapt for other tenants/repos. - The
with_entries(select(.key | test(...)))filters for annotations and labels are quite specific; it may be worth adding a brief inline comment near each explaining what categories are intentionally preserved vs. stripped to make future modifications safer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The retry script hardcodes values like the `calunga-tenant` namespace, `.tekton/build-pipeline.yaml` path, and `git-auth-dummy` secret; consider calling these out as variables/placeholders at the top of the snippet so they’re easier to adapt for other tenants/repos.
- The `with_entries(select(.key | test(...)))` filters for annotations and labels are quite specific; it may be worth adding a brief inline comment near each explaining what categories are intentionally preserved vs. stripped to make future modifications safer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Document a safe procedure for retrying failed on-push pipelines and correct a configuration typo in the build pipeline.
Enhancements:
git-clone-depthdescription field.Documentation: